lkml.org 
[lkml]   [2011]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH 2/9] ASoC: da7210: Add support for line input and mic
On Wed, Oct 12, 2011 at 08:28:12PM +0530, Ashish Chavan wrote:

> +static const char *da7210_mic_bias_voltage_txt[] = {
> + "1.5", "1.6", "2.2", "2.3"
> +};
> +
> +static const struct soc_enum da7210_mic_bias =
> + SOC_ENUM_SINGLE(DA7210_MIC_L, 4, 4, da7210_mic_bias_voltage_txt);
> +

This shouldn't be application controllable, it's a board property and if
it needs to be managed it's likely to be by in kernel things like
accessory detection. We do have some older drivers that do this but
they're not good. Use platform data.


\
 
 \ /
  Last update: 2011-10-12 16:55    [W:0.033 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site