lkml.org 
[lkml]   [2011]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch 5/11] Regulator: DA9052/53 regulator support v4
(2011年10月07日 20:20), ashishj3 wrote:
> The Dialog PMIC has below featured regulators:-
> DA9052-BC - 4 DVS Buck converters 0.5V - 3.6V upto 1Amp.
> DA9053-AA/BX - 4 DVS Buck converters 0.5V - 2.5V upto 3Amp.
> DA9052/53 - 10 Programmable LDO's High PSSR, 1% accuracy.
>
> This patch support all the DA9052 and Da9053 regulators. The output voltages are
> fully programmable via I2C or SPI interface. The platform data with regulation
> constraints is passed down from the board to the regulator.
>
> Signed-off-by: David Dajun Chen <dchen@diasemi.com>
> Signed-off-by: Ashish Jangam <ashish.jangam@kpitcummins.com>
> CC: Mark Brown <broonie@opensource.wolfsonmicro.com>

Tested-by: Ying-Chun Liu (PaulLiu) <paul.liu@linaro.org>

Hi,

I've reviewed the source code and tested this driver on imx53 QuickStart
board. Works good.

There are some minor warnings and error by running checkpatch.pl on this
patch.

WARNING: please write a paragraph that describes the config symbol fully
#50: FILE: drivers/regulator/Kconfig:173:
+ help

ERROR: do not set execute permissions for source files
#70: FILE: drivers/regulator/da9052-regulator.c

WARNING: line over 80 characters
#117: FILE: drivers/regulator/da9052-regulator.c:43:
+ {800000, 1000000, 1200000, 1500000}, /* DA9053-AA/Bx BUCK-PRO,MEM,PERI */

Yours Sincerely,
Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-10-12 15:59    [W:0.034 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site