lkml.org 
[lkml]   [2011]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/13] drbd: cosmetic: fix accidental division instead of modulo when pretty printing
    Date
    From: Lars Ellenberg <lars.ellenberg@linbit.com>

    For large resync rates, seq_printf_with_thousands_grouping()
    accidentally only produced Y,000,00Y, instead of the real numbers.

    Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
    Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
    ---
    drivers/block/drbd/drbd_proc.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/block/drbd/drbd_proc.c b/drivers/block/drbd/drbd_proc.c
    index 6b226cc..7e68d99 100644
    --- a/drivers/block/drbd/drbd_proc.c
    +++ b/drivers/block/drbd/drbd_proc.c
    @@ -52,7 +52,7 @@ void seq_printf_with_thousands_grouping(struct seq_file *seq, long v)
    if (unlikely(v >= 1000000)) {
    /* cool: > GiByte/s */
    seq_printf(seq, "%ld,", v / 1000000);
    - v /= 1000000;
    + v %= 1000000;
    seq_printf(seq, "%03ld,%03ld", v/1000, v % 1000);
    } else if (likely(v >= 1000))
    seq_printf(seq, "%ld,%03ld", v/1000, v % 1000);
    --
    1.7.4.1


    \
     
     \ /
      Last update: 2011-10-12 14:33    [W:0.022 / U:30.688 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site