lkml.org 
[lkml]   [2011]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/4] staging: et131x: Update TODO list
From
On Tue, Oct 11, 2011 at 11:40 AM, Denis Kirjanov <kirjanov@gmail.com> wrote:
> If you look at the patch once again then you find some
>
> On Tue, Oct 11, 2011 at 9:25 PM, Ramesh R <rshlinux@gmail.com> wrote:
>> Thanks Mark,
>>
>> Are there any open items left in the TODO list for this driver at this point?
>>
>> Regards
>> Ramesh
>>
>> On Tue, Oct 11, 2011 at 9:25 AM, Mark Einon <mark.einon@gmail.com> wrote:
>>> On 11 October 2011 17:11, Greg KH <gregkh@suse.de> wrote:
>>>> On Tue, Oct 11, 2011 at 09:00:35AM -0700, Ramesh R wrote:
>>>>> Hi Mark,
>>>>>
>>>>> I wish to contribute to this project - From the latest TODO list in
>>>>> the README document
>>>>>
>>>>> drivers/staging/et131x/README
>>>>>
>>>>> If I were to start with the coding style cleanups, is there a coding
>>>>> standard available for reference? Please advice.
>>>>
>>>> Documentation/CodingStyle
>>>>
>>> Ramesh,
>>>
>>> There are no significant coding style issues with this particular
>>> driver at this time, as far as I (and the checkpatch script) are aware
>>> of.
>>> I suggest you check other staging/ drivers for these sorts of issues.
>>>
>>> Cheers,
>>>
>>> Mark
>>>
>> _______________________________________________
>> devel mailing list
>> devel@linuxdriverproject.org
>> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>>

Thank you, got a few items.

I could work on item #1,
==
TODO:
+ - Put the driver into a single file, with a .h for the registers layout.
+ - rx_ring.fbr{0, 1} can probably share a common structure
+ - Use of kmem_cache seems a bit unusual
+ - Use dma_alloc_... in place of pci_alloc_...
+ - It's too late stopping the tx queue when there is no room
for the current packet. The condition should be detected for the next
packet.
+ - PCI_VDEVICE ?

==

I looked up for ET 1310 on ebay, amazon & few other sites like digikey
- I couldnt find the device. Can you please let me know where I can
buy the hardware?

/Ramesh


\
 
 \ /
  Last update: 2011-10-12 04:41    [W:0.067 / U:9.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site