lkml.org 
[lkml]   [2011]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] Staging: comedi: fix printk and line over 80
From
Date
On Mon, 10 Oct 2011 19:28:53 +0530, Ravishankar Karkala Mallikarjunayya said:
> This patch fixes a printk and line over 80 charcter found by the
> checkpatch.pl tool

> @@ -503,7 +512,7 @@ static int probe(struct comedi_device *dev, const struct comedi_devconfig *it)
> }
> }
>
> - printk("cb_pcimdda: No supported ComputerBoards/MeasurementComputing "
> + pr_err("cb_pcimdda: No supported ComputerBoards/MeasurementComputing "
> "card found at the requested position\n");
> return -ENODEV;
> }

As long as we're changing this code, should we be splicing the two parts of the
string back together? (And yes, that *does* trump the 80-col rule)
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-10-11 23:37    [W:0.103 / U:3.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site