lkml.org 
[lkml]   [2011]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v3] drivercore: Add driver probe deferral mechanism
On 10/11/2011 01:47 PM, Andrew Morton wrote:
> On Thu, 22 Sep 2011 12:51:23 -0600
> Grant Likely<grant.likely@secretlab.ca> wrote:
>
>> Allow drivers to report at probe time that they cannot get all the resources
>> required by the device, and should be retried at a later time.
>>
>> This should completely solve the problem of getting devices
>> initialized in the right order. Right now this is mostly handled by
>> mucking about with initcall ordering which is a complete hack, and
>> doesn't even remotely handle the case where device drivers are in
>> modules. This approach completely sidesteps the issues by allowing
>> driver registration to occur in any order, and any driver can request
>> to be retried after a few more other drivers get probed.
>
> What happens is there is a circular dependency, or if a driver's
> preconditions are never met? AFAICT the code keeps running the probe
> function for ever.
>

The deferred probe functions are only run once per (other) driver
binding event. So once you quit registering new drivers, no further
probing is done. There is no endless loop happening here.

If the preconditions are never met, the driver will just sit in the list
waiting.


> If so: bad. The kernel should detect such situations, should
> exhaustively report them and if possible, fix them up and struggle
> onwards.
>

I don't think we should actively report anything, but being able to
inspect the deferred probe list from user space might be useful for
diagnosing problems


David Daney



\
 
 \ /
  Last update: 2011-10-11 23:11    [from the cache]
©2003-2011 Jasper Spaans