lkml.org 
[lkml]   [2011]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[16/38] drm/radeon/kms: Fix logic error in DP HPD handler
    3.0-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Alex Deucher <alexander.deucher@amd.com>

    commit 5ba7ddf81634bfdf32d09261d2959e3f5b7c4263 upstream.

    Only disable the pipe if the monitor is physically
    disconnected. The previous logic also disabled the
    pipe if the link was trained.

    Fixes:
    https://bugs.freedesktop.org/show_bug.cgi?id=41248

    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Dave Airlie <airlied@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/gpu/drm/radeon/radeon_connectors.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/drivers/gpu/drm/radeon/radeon_connectors.c
    +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
    @@ -68,11 +68,11 @@ void radeon_connector_hotplug(struct drm
    if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
    int saved_dpms = connector->dpms;

    - if (radeon_hpd_sense(rdev, radeon_connector->hpd.hpd) &&
    - radeon_dp_needs_link_train(radeon_connector))
    - drm_helper_connector_dpms(connector, DRM_MODE_DPMS_ON);
    - else
    + /* Only turn off the display it it's physically disconnected */
    + if (!radeon_hpd_sense(rdev, radeon_connector->hpd.hpd))
    drm_helper_connector_dpms(connector, DRM_MODE_DPMS_OFF);
    + else if (radeon_dp_needs_link_train(radeon_connector))
    + drm_helper_connector_dpms(connector, DRM_MODE_DPMS_ON);
    connector->dpms = saved_dpms;
    }
    }



    \
     
     \ /
      Last update: 2011-10-11 19:09    [W:0.021 / U:89.728 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site