lkml.org 
[lkml]   [2011]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [patch]ext4: add block plug for .writepages
    From
    On Tue, Oct 11, 2011 at 1:51 AM, Ted Ts'o <tytso@mit.edu> wrote:
    > On Wed, Sep 28, 2011 at 11:09:40AM +0800, Shaohua Li wrote:
    >> I searched a little bit, looks only ext4 need it. here is the patch.
    >>
    >>
    >> Add block plug for ext4 .writepages. Though ext4 .writepages
    >> already handles request merge very well, block plug is still
    >> helpful to reduce block lock contention.
    >>
    >> Signed-off-by: Shaohua Li <shaohua.li@intel.com>

    Does it require to add blk_finish_plug(&plug) when error case?

    + blk_start_plug(&plug);
    while (!ret && wbc->nr_to_write > 0) {

    ...
    /* start a new transaction*/
    handle = ext4_journal_start(inode, needed_blocks);
    if (IS_ERR(handle)) {
    ret = PTR_ERR(handle);
    ext4_msg(inode->i_sb, KERN_CRIT, "%s: jbd2_start: "
    "%ld pages, ino %lu; err %d", __func__,
    wbc->nr_to_write, inode->i_ino, ret);
    + blk_finish_plug(&plug);
    goto out_writepages;
    }

    Thank you,
    Kyungmin Park-


    \
     
     \ /
      Last update: 2011-10-11 12:43    [W:0.022 / U:154.664 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site