lkml.org 
[lkml]   [2011]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] regmap: Allow caches for devices with no defaults
    On Sun, Oct 09, 2011 at 02:44:36PM +0100, Mark Brown wrote:
    > We only really need the defaults in order to cut down the number of
    > registers we sync and to satisfy reads while the device is powered off
    > but not all devices are going to need to do that (always on devices like
    > PMICs being the prime example) so don't require those devices to supply
    > a default. Instead only try to fall back to hardware defaults if the
    > driver told us to.
    >
    > Devices using LZO won't be able to instantiate with this, that will require
    > some updates in the LZO code to handle this case.
    >
    > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
    > ---
    > drivers/base/regmap/regcache.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
    > index 67c7703..666f6f5 100644
    > --- a/drivers/base/regmap/regcache.c
    > +++ b/drivers/base/regmap/regcache.c
    > @@ -120,7 +120,7 @@ int regcache_init(struct regmap *map)
    > if (!tmp_buf)
    > return -ENOMEM;
    > map->reg_defaults = tmp_buf;
    > - } else {
    > + } else if (map->num_reg_defaults_raw) {
    > /* Some devices such as PMICs don't have cache defaults,
    > * we cope with this by reading back the HW registers and
    > * crafting the cache defaults by hand.
    > --
    > 1.7.6.3

    We could probably then also remove the first check in
    regcache_hw_init() I guess.

    The one:

    if (!map->num_reg_defaults_raw)
    return -EINVAL;

    Thanks,
    Dimitris


    \
     
     \ /
      Last update: 2011-10-10 10:43    [W:0.020 / U:1.516 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site