lkml.org 
[lkml]   [2011]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: RFC: virtualbox tainting.
Hey Dave,

On 10/06/2011 09:05 PM, Dave Jones wrote:
> The number of bug reports we get from people with virtualbox loaded are
> truly astonishing. It's GPL, but sadly that doesn't mean it's good.
> Nearly all of these bugs look like random corruption. (corrupt linked lists,
> corrupt page tables, and just plain 'weird' crashes).
>
> This diff adds tainting to the module loader to treat it as we do with stuff
> from staging/ (crap). With this tainting in place, automatic bug filing tools
> can opt out of automatically filing kernel bugs, and inform the user to file
> bugs somewhere more appropriate.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> diff --git a/kernel/module.c b/kernel/module.c
> index 04379f92..d26c9a3 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -2653,6 +2653,10 @@ static int check_module_license_and_versions(struct module *mod)
> if (strcmp(mod->name, "ndiswrapper") == 0)
> add_taint(TAINT_PROPRIETARY_MODULE);
>
> + /* vbox is garbage. */
> + if (strcmp(mod->name, "vboxdrv") == 0)
> + add_taint(TAINT_CRAP);
> +
> /* driverloader was caught wrongly pretending to be under GPL */
> if (strcmp(mod->name, "driverloader") == 0)
> add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
Patch vbox' kernel modules instead?
Seems to mark it as crap, all you have to do is add this to the driver source:
MODULE_INFO(staging, "Y");

Tested this theory by adding that line to snd-usb-audio, it immediately tainted kernel. :)

Cheers,
Maarten


\
 
 \ /
  Last update: 2011-10-10 10:43    [W:0.084 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site