lkml.org 
[lkml]   [2011]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 4/4] staging: et131x: Update TODO list
Date
Added some more tasks to the TODO list, as highlighted by Francois
Romieu <romieu@fr.zoreil.com>.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
---
drivers/staging/et131x/README | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README
index d383e80..c67f83e 100644
--- a/drivers/staging/et131x/README
+++ b/drivers/staging/et131x/README
@@ -2,13 +2,18 @@ This is a driver for the ET1310 network device.

Based on the driver found at https://sourceforge.net/projects/et131x/

-Cleaned up immensely by Olaf Hartman and Christoph
-Hellwig <hch@infradead.org>
+Cleaned up immensely by Olaf Hartman and Christoph Hellwig <hch@infradead.org>

Note, the powermanagement options were removed from the vendor provided
driver as they did not build properly at the time.

TODO:
+ - Put the driver into a single file, with a .h for the registers layout.
+ - rx_ring.fbr{0, 1} can probably share a common structure
+ - Use of kmem_cache seems a bit unusual
+ - Use dma_alloc_... in place of pci_alloc_...
+ - It's too late stopping the tx queue when there is no room for the current packet. The condition should be detected for the next packet.
+ - PCI_VDEVICE ?

Please send patches to:
Greg Kroah-Hartman <gregkh@suse.de>
--
1.7.6.4


\
 
 \ /
  Last update: 2011-10-10 17:27    [W:0.072 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site