lkml.org 
[lkml]   [2011]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/8] staging: et131x: Add pci suspend & resume functions
    Mark Einon <mark.einon@gmail.com> :
    > On 1 October 2011 12:03, Francois Romieu <romieu@fr.zoreil.com> wrote:
    [...]
    > >> + ? ? err = et131x_open(netdev);
    > >> + ? ? if (err) {
    > >> + ? ? ? ? ? ? dev_err(&pdev->dev, "Can't resume interface!\n");
    > >> + ? ? ? ? ? ? goto out;
    > >> + ? ? }
    > >
    > > You can/should split et131x_{open/close} to remove this failure point.
    >
    > Hi, thanks for the comments francois,
    > I'm not quite sure what you mean here. Can you expand on your comment please?

    Something like:

    int et131x_open(struct net_device *netdev)
    {
    add_timer(...)

    err = request_irq(...)
    if (err < 0)
    goto release_timer;

    et131x_start(...)

    out:
    return err;

    release_timer:
    blah;
    goto out;
    }

    Same thing with et131x_close / et131x_stop. You only use et131x_{start/stop}
    for suspend/resume : one error path is gone away.

    --
    Ueimor


    \
     
     \ /
      Last update: 2011-10-01 21:41    [W:0.021 / U:0.460 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site