Messages in this thread | | | Subject | Re: [PATCH 4/5] Coding style in serial2002 Patch that resolves braces and KERN_ warnings by checkpatch.pl Signed-off-by: Michael Ahern | From | Joe Perches <> | Date | Sun, 09 Jan 2011 15:56:05 -0800 |
| |
On Mon, 2011-01-10 at 10:03 +1100, ahern.michael.t@gmail.com wrote: > From: mah <ahern.michael.t@gmail.com>
Hi Michael, just trivia.
> drivers/staging/comedi/drivers/serial2002.c | 206 ++++++++++++--------------- > @@ -451,23 +454,23 @@ static int serial_2002_open(struct comedi_device *dev) > command = (data.value >> 8) & 0x3; > switch (kind) { > case 1:{ > - cur_config = dig_in_config; > + cur_config = dig_in_config; > } > break; > case 2:{
You could remove the braces from all the case labels as well.
[]
> + switch (unit) { > + case 0:{ > + min = min * 1000000;
Perhaps *= 1000000 and *= 1000
| |