lkml.org 
[lkml]   [2011]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 4/5] Coding style in serial2002 Patch that resolves braces and KERN_ warnings by checkpatch.pl Signed-off-by: Michael Ahern
    From
    Date
    On Mon, 2011-01-10 at 10:03 +1100, ahern.michael.t@gmail.com wrote:
    > From: mah <ahern.michael.t@gmail.com>

    Hi Michael, just trivia.

    > drivers/staging/comedi/drivers/serial2002.c | 206 ++++++++++++---------------
    > @@ -451,23 +454,23 @@ static int serial_2002_open(struct comedi_device *dev)
    > command = (data.value >> 8) & 0x3;
    > switch (kind) {
    > case 1:{
    > - cur_config = dig_in_config;
    > + cur_config = dig_in_config;
    > }
    > break;
    > case 2:{

    You could remove the braces from all the case labels as well.

    []

    > + switch (unit) {
    > + case 0:{
    > + min = min * 1000000;

    Perhaps *= 1000000 and *= 1000




    \
     
     \ /
      Last update: 2011-01-10 00:59    [W:0.020 / U:0.060 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site