lkml.org 
[lkml]   [2011]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Cleanup include/net/tcp.h include-files and coding-style
    On Sun, Jan 09, 2011 at 09:55:34PM +0100, Christoph Paasch wrote:
    > This patch reviews the include-files of net/tcp.h
    > Several #include where redundant. Some where not directly needed by
    > net/tcp.h
    >
    > Files, including net/tcp.h where also including some the *.h-files that
    > net/tcp.h is already including. Thus, in these files the inclusion of
    > the *.h file is unnecessary.
    >
    > Redundant includes in net/tcp.h:
    >
    > linux/list.h --- included by linux/textsearch.h which is included by
    > linux/skbuff.h
    > linux/slab.h --- included by linux/crypto.h
    > linux/cache.h --- included by linux/skbuff.h
    > linux/skbuff.h --- included by net/sock.h
    > linux/kref.h --- included by linux/kobject.h, which is included by
    > linux/device.h, which is included by
    > linux/dmaengine.h, which is included by
    > linux/skbuff.h
    > net/inet_connection_sock.h --- included by net/inet_hashtables.h
    > net/checksum.h --- included by net/sock.h
    > net/request_sock.h --- included by net/inet_connection_sock.h
    > net/sock.h --- included by net/request_sock.h
    > net/snmp.h --- included by net/ip.h
    > net/dst.h --- included by net/sock.h
    > linux/seq_file.h --- included by net/neighbour.h, which is included by
    > net/dst.h
    >
    > Include-files not directly needed by net/tcp.h:
    >
    > linux/percpu.h
    > linux/dmaengine.h

    DMA stuff "dereferenced" in tcp_prequeue_init().

    > net/tcp_states.h
    > net/inet_ecn.h

    NAK

    Where is the logic?

    include/net/tcp.h _does_ use kref, so it needs kref.h
    include/net/tcp.h _does_ use list_head, so it needs list.h

    and so on.


    \
     
     \ /
      Last update: 2011-01-09 23:33    [from the cache]
    ©2003-2011 Jasper Spaans