lkml.org 
[lkml]   [2011]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv1 01/12] unicore32 core architecture: build infrastructure
    > > > +textofs-y	:= 0x00408000
    > > > +
    > > > +# The byte offset of the kernel image in RAM from the start of RAM.
    > > > +TEXT_OFFSET := $(textofs-y)
    > >
    > > If you are going to have different TEXT_OFFSET's then I suggest to move
    > > this to KConfig as an "hex "Text offset" config option.
    > > You can set default values dependign on BSP etc.
    > There is no different TEXT_OFFSET.
    >
    > >
    > > Also defiing stuff here just to export it for use in boot/
    > > has always looked like a strange concept - but many archs do so today.
    > > You do not export TEXT_OFFSET but I guess this is a bug?
    > I need TEXT_OFFSET for kernel/ and boot/, so export it.

    I would suggest to move this to you Kconfig file.
    something like this:

    # The byte offset of the kernel image in RAM from the start of RAM
    config UNICORE32_TEXT_OFFSET
    hex
    default 0x00408000

    Then you have the symbol available as CONFIG_UNICORE32_TEXT_OFFSET
    both in your Makefiles and in your source files.
    > >
    > > > +
    > > > +core-y += arch/unicore32/kernel/ arch/unicore32/mm/
    > > > +core-$(CONFIG_UNICORE_FPU_F64) += arch/unicore32/uc-f64/
    > > > +
    > > > +drivers-$(CONFIG_ARCH_PUV3) += drivers/staging/puv3/
    > > > +
    > > > +libs-y += arch/unicore32/lib/
    > > > +# include libc.a in libs-y for string functions, like memcpy and so on.
    > > > +libs-y += $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libc.a)
    > > > +libs-y += $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libgcc.a)
    > > > +
    > >
    > > The other three archs that uses libgcc use:
    > >
    > > $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)
    > >
    > > So when I read the above I am confused why it looks different than the others.
    > > For libc I guess you do nto have that option and what you do is fine there.
    > It's the same with -print-libgcc-file-name and -print-file-name=libgcc.a.
    > And we need libc.a for string like functions.

    And then they use equal methods - OK.

    Sam


    \
     
     \ /
      Last update: 2011-01-08 12:51    [W:0.022 / U:0.020 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site