lkml.org 
[lkml]   [2011]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: + hugetlb-handle-nodemask_alloc-failure-correctly.patch added to -mm tree
On Thu 06-01-11 16:42:06, David Rientjes wrote:
> On Thu, 6 Jan 2011, akpm@linux-foundation.org wrote:
[...]
> This patch is wrong, both functions may handle a NULL nodes_allowed, which
> is why the __GFP_NORETRY is explicitly part of the gfp mask.
>
> In both functions, init_nodemask_of_mempolicy() will immediately return
> false if the mask is NULL. If so, it is set to node_states[N_HIGH_MEMORY]
> in the caller and we're careful to avoid calling the NODMASK_FREE() in
> that case. They are carefully coded in this way so they operate over all
> nodes with memory rather than failing with -ENOMEM.

OK, I see. Thanks for the review.

--
Michal Hocko
L3 team
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic


\
 
 \ /
  Last update: 2011-01-07 09:27    [W:0.051 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site