lkml.org 
[lkml]   [2011]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V2] platform-driver-x86: ACPI EC Extra driver for Oaktrail
    On Fri, Jan 07, 2011 at 03:41:15PM +0800, Yin Kangkai wrote:

    > This driver implements an Extra ACPI EC driver for products based on Intel
    > Oaktrail platform. It is programming the EC space, through existing ACPI EC
    > driver, to provide user space layer the sysfs and rfkill interfaces to
    > enable/disable the Camera, Bluetooth, GPS, WiFi, 3G, and to show the status of
    > Touchscreen.

    As far as I can tell, the only ACPI aspect of this driver is that it
    makes use of the ACPI EC driver? In that case I think the name's
    misleading.

    > @@ -0,0 +1,13 @@
    > +What: /sys/devices/platform/intel_oaktrail/camera
    > +Date: Jan 2011
    > +KernelVersion: 2.6.37
    > +Contact: "Yin Kangkai" <kangkai.yin@intel.com>
    > +Description:
    > + Control the camera. 1 means on, 0 means off.

    We really need a better approach for this kind of thing...

    > +What: /sys/devices/platform/intel_oaktrail/touchscreen
    > +Date: Jan 2011
    > +KernelVersion: 2.6.37
    > +Contact: "Yin Kangkai" <kangkai.yin@intel.com>
    > +Description:
    > + Show the status of the touch screen. 1 means on, 0 means off.

    And this one, but we don't have one yet so I think this is ok.

    > + wwan_rfkill = oaktrail_rfkill_new("oaktrail-wwan",
    > + RFKILL_TYPE_WWAN,
    > + OT_EC_WWAN_MASK);

    Do you have any way to identify whether the hardware has all these
    features before registering?

    > +static struct dmi_system_id __initdata oaktrail_dmi_table[] = {
    > + {
    > + .ident = "OakTrail platform",
    > + .matches = {
    > + DMI_MATCH(DMI_PRODUCT_NAME, "OakTrail platform"),
    > + },
    > + .callback = dmi_check_cb
    > + },
    > + { }
    > +};

    Is any hardware actually going to ship with this identifier, or will
    vendors change the string?

    --
    Matthew Garrett | mjg59@srcf.ucam.org


    \
     
     \ /
      Last update: 2011-01-07 23:13    [W:0.055 / U:31.548 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site