Messages in this thread | | | Date | Fri, 7 Jan 2011 13:58:18 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: use PCI method for enabling AMD extended config space before MSR method |
| |
* Robert Richter <robert.richter@amd.com> wrote:
> On 06.01.11 18:20:04, Robert Richter wrote: > > On 06.01.11 11:57:35, Jan Beulich wrote: > > > While both methods should work equivalently well for the native case, > > > the Xen Dom0 case can't reliably work with the MSR one, since there's > > > no guarantee that the virtual CPUs it has available fully cover all > > > necessary physical ones. > > > > > > As per the suggestion of Robert Richter the patch only adds the PCI > > > method, but leaves the MSR one as a fallback to cover new systems the > > > PCI IDs of which may not have got added to the code base yet. > > > > > > Signed-off-by: Jan Beulich <jbeulich@novell.com> > > > Cc: Robert Richter <robert.richter@amd.com> > > > Cc: Joerg Roedel <Joerg.Roedel@amd.com> > > > Cc: Andreas Herrmann <Andreas.Herrmann3@amd.com> > > > Cc: Jeremy Fitzhardinge <jeremy@goop.org> > > > > > > --- > > > arch/x86/include/asm/amd_nb.h | 7 ++++++ > > > arch/x86/kernel/amd_nb.c | 7 ++++++ > > > arch/x86/kernel/aperture_64.c | 44 +++++++++++++++--------------------------- > > > arch/x86/pci/amd_bus.c | 30 ++++++++++++++++++++++++++++ > > > 4 files changed, 60 insertions(+), 28 deletions(-) > > Btw, the patch should be relative to tip/x86/amd-nb as there would be > conflicts otherwise due to other changes.
that's upstream meanwhile, so a patch against -git or -tip would suffice.
Thanks,
Ingo
| |