lkml.org 
[lkml]   [2011]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 22/36] serial: fix pch_uart kconfig & build
    On Fri, Jan 07, 2011 at 09:21:43AM +0900, Tomoya MORINAGA wrote:
    > Hi Greg,
    >
    > On Friday, January 07, 2011 7:23 AM, Greg Kroah-Hartman wrote:
    > > Also, the help text says that the
    > > driver enables & uses PCH_DMA, which is not enabled, so select that.
    >
    > I think PCH_DMA is not always used when a user uses PCH_UART.
    > Since overhead of DMA is not small, in case of low frequent communication,
    > without DMA is better.
    > Thus, I think "select PCH_DMA" is unnecessary
    >
    > (Of course, the PCH_UART works both with/without PCH_DMA.)

    Patches are always welcome to fix things up :)

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2011-01-07 01:35    [W:0.020 / U:0.112 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site