lkml.org 
[lkml]   [2011]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] input: tegra-kbc - Add tegra keyboard driver
On Thu, 6 Jan 2011 23:15:01 +0100 (CET) Jesper Juhl wrote:

> > +fail:
> > + if (kbc->irq >= 0)
> > + free_irq(kbc->irq, pdev);
> > + if (kbc->idev)
> > + input_free_device(kbc->idev);
>
> As far as I can tell input_free_device() deals gracefully with being
> passed a null pointer, so the 'if' seems superfluous.
>
>
> --
> Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
> Plain text mails only, please.
+ Please trim replies to the relevant part(s) of patches.


thnx,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***


\
 
 \ /
  Last update: 2011-01-06 23:29    [W:0.142 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site