Messages in this thread | | | Date | Thu, 6 Jan 2011 13:34:55 +0000 | From | Alan Cox <> | Subject | Re: [PATCH] RS485 on Cris: use global value of TIOCSRS485 |
| |
> With this patch, TIOCSRS485 gets the same value across all > architectures, making maintenance and portability of user-level code > easier.
I don't see why this is worth doing - no application code should ever hardcode the value.
> + case TIOCSRS485DEPR: > + { > + printk(KERN_DEBUG "The use of this ioctl is deprecated. Use TIOCSRS485 instead\n"); > + /* Fall through */ > + }
and letting everyone spew printks is not a good thing.
NAK
| |