Messages in this thread | | | Date | Wed, 5 Jan 2011 14:43:06 -0800 | From | Greg KH <> | Subject | Re: [PATCH 1/1] mct_u232: added _ioctl, _msr_to_icount and _get_icount functions |
| |
On Mon, Dec 27, 2010 at 12:55:38PM -0800, Tsozik wrote: > Pete, > > You're absolutely right. My apology again, I re-checked values of MSR masks used to update icount counters and they all belong to upper MSR nibble, so they indeed track changes (not states). I took out counter increments from mct_u232_msr_to_state function and encapsulated them in the newly defined mct_u232_msr_to_icount function, effectively leaving the previous implementation of mct_u232_msr_to_state function intact. mct_u232_msr_to_icount uses delta nibble to track state changes. RM-60 testing showed the same levels as measured by PDM-2 in close proximity to RM-60. Please let me know if anything else needs to be corrected to roll this out,
Can you not attach the patch as a base64 attachment? I can't apply it as-is, because of that, sorry.
thanks,
greg k-h
| |