Messages in this thread | | | Date | Wed, 5 Jan 2011 09:46:01 -0800 | From | Chris Wright <> | Subject | Re: [PATCH] PCI: sysfs: Update ROM to include default owner write access |
| |
* Alex Williamson (alex.williamson@redhat.com) wrote: > The PCI sysfs ROM interface requires an enabling write to access > the ROM image, but the default file mode is 0400. The original > proposed patch adding sysfs ROM support was a true read-only > interface, with the enabling bit coming in as a feature request. > I suspect it was simply an oversight that the file mode didn't > get updated to match the API.
This is often not an issue given normal root capabilities, but once we strip those capabilities, the default 0400 causes O_RDWR to fail. As Alex said, given the only way to use the file is to write to it first, making it writable makes sense.
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Acked-by: Chris Wright <chrisw@redhat.com>
| |