Messages in this thread Patch in this message | | | Date | Tue, 4 Jan 2011 08:19:56 GMT | From | tip-bot for Arnaldo Carvalho de Melo <> | Subject | [tip:perf/core] perf script: Fix event ordering settings to work with older kernels |
| |
Commit-ID: ce0ac9e1851364fa67c991659ce1db05ab82c6ae Gitweb: http://git.kernel.org/tip/ce0ac9e1851364fa67c991659ce1db05ab82c6ae Author: Arnaldo Carvalho de Melo <acme@redhat.com> AuthorDate: Sat, 25 Dec 2010 18:33:12 -0200 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Sat, 25 Dec 2010 18:33:12 -0200
perf script: Fix event ordering settings to work with older kernels
If we don't use .ordering_requires_timestamps we'll end up trying to order events with no timestamps when running on older kernels.
Problem introduced in eac23d1c.
After the last three fixes, perf scripting is back working, tested with new perf userspace on old and new (with sample_id_all) kernels.
Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ian Munsie <imunsie@au1.ibm.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Mike Galbraith <efault@gmx.de> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Cc: Tom Zanussi <tzanussi@gmail.com> Cc: Torok Edwin <edwintorok@gmail.com> LKML-Reference: <new-submission> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/builtin-script.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c index 6ef65c0..43480fd 100644 --- a/tools/perf/builtin-script.c +++ b/tools/perf/builtin-script.c @@ -117,6 +117,7 @@ static struct perf_event_ops event_ops = { .tracing_data = event__process_tracing_data, .build_id = event__process_build_id, .lost = process_lost_event, + .ordering_requires_timestamps = true, .ordered_samples = true, };
| |