lkml.org 
[lkml]   [2011]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:sched/core] sched, autogroup: Fix reference leak
    Commit-ID:  101e5f77bf35679809586e250b6c62193d2ed179
    Gitweb: http://git.kernel.org/tip/101e5f77bf35679809586e250b6c62193d2ed179
    Author: Mike Galbraith <efault@gmx.de>
    AuthorDate: Fri, 31 Dec 2010 09:32:30 +0100
    Committer: Ingo Molnar <mingo@elte.hu>
    CommitDate: Tue, 4 Jan 2011 15:10:36 +0100

    sched, autogroup: Fix reference leak

    The cgroup exit mess also uncovered a struct autogroup reference leak.
    copy_process() was simply freeing vs putting the signal_struct,
    stranding a reference.

    Signed-off-by: Mike Galbraith <efault@gmx.de>
    Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Oleg Nesterov <oleg@redhat.com>
    LKML-Reference: <1293784350.6839.2.camel@marge.simson.net>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    ---
    kernel/fork.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/kernel/fork.c b/kernel/fork.c
    index b6f2475..0672444 100644
    --- a/kernel/fork.c
    +++ b/kernel/fork.c
    @@ -1317,7 +1317,7 @@ bad_fork_cleanup_mm:
    }
    bad_fork_cleanup_signal:
    if (!(clone_flags & CLONE_THREAD))
    - free_signal_struct(p->signal);
    + put_signal_struct(p->signal);
    bad_fork_cleanup_sighand:
    __cleanup_sighand(p->sighand);
    bad_fork_cleanup_fs:

    \
     
     \ /
      Last update: 2011-01-04 15:23    [W:0.022 / U:153.412 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site