Messages in this thread | | | Date | Tue, 4 Jan 2011 13:59:18 +0800 | Subject | Re: [RFC][PATCH 08/17] sched: Drop the rq argument to sched_class::select_task_rq() | From | Yong Zhang <> |
| |
On Mon, Jan 3, 2011 at 7:16 PM, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote: > On Wed, 2010-12-29 at 22:31 +0800, Yong Zhang wrote: >> On Fri, Dec 24, 2010 at 01:23:46PM +0100, Peter Zijlstra wrote: >> > In preparation of calling select_task_rq() without rq->lock held, drop >> > the dependency on the rq argument. >> > >> > Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> >> > --- >> > @@ -3416,27 +3409,22 @@ void sched_exec(void) >> > { >> > struct task_struct *p = current; >> > unsigned long flags; >> > - struct rq *rq; >> > int dest_cpu; >> > >> > - rq = task_rq_lock(p, &flags); >> > - dest_cpu = p->sched_class->select_task_rq(rq, p, SD_BALANCE_EXEC, 0); >> > + raw_spin_lock_irqsave(&p->pi_lock, flags); >> >> Seems this should go to patch 07/17 ;) > > Ah, the reason its here is that this patch removes the rq argument and > thus we no longer need rq->lock. So this part relies on the property > introduced by patch 7.
What I mean is we could firstly add pi_lock in patch 7 and then remove the rq argument in this patch. :)
Thanks, Yong
-- Only stand for myself -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |