Messages in this thread | | | Subject | Re: [PATCH 2/2] s390: Fix possibly wrong size in strncmp (smsglucv) | From | Ursula Braun <> | Date | Mon, 31 Jan 2011 11:44:14 +0100 |
| |
Ack - thanks, Stefan.
We have added your smsgiucv patch to our local repository. It will be part of our next patch collection submitted to Dave Miller for upstream integration.
Regards, Ursula
On Sat, 2011-01-29 at 22:33 +0100, Stefan Weil wrote: > This error was reported by cppcheck: > drivers/s390/net/smsgiucv.c:63: error: Using sizeof for array given as function argument returns the size of pointer. > > Although there is no runtime problem as long as sizeof(u8 *) == 8, > this misleading code should get fixed. > > Cc: Ursula Braun <ursula.braun@de.ibm.com> > Cc: linux390@de.ibm.com > Cc: Frank Blaschka <blaschka@linux.vnet.ibm.com> > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> > Cc: Heiko Carstens <heiko.carstens@de.ibm.com> > Cc: linux-s390@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Stefan Weil <weil@mail.berlios.de> > --- > drivers/s390/net/smsgiucv.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/s390/net/smsgiucv.c b/drivers/s390/net/smsgiucv.c > index 65e1cf1..207b7d7 100644 > --- a/drivers/s390/net/smsgiucv.c > +++ b/drivers/s390/net/smsgiucv.c > @@ -60,7 +60,7 @@ static struct iucv_handler smsg_handler = { > static int smsg_path_pending(struct iucv_path *path, u8 ipvmid[8], > u8 ipuser[16]) > { > - if (strncmp(ipvmid, "*MSG ", sizeof(ipvmid)) != 0) > + if (strncmp(ipvmid, "*MSG ", 8) != 0) > return -EINVAL; > /* Path pending from *MSG. */ > return iucv_path_accept(path, &smsg_handler, "SMSGIUCV ", NULL);
| |