lkml.org 
[lkml]   [2011]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] i2c-gpio: add devicetree support
    On Mon, Jan 31, 2011 at 02:35:31PM -0800, Håvard Skinnemoen wrote:
    > Hi,
    >
    > On Mon, Jan 31, 2011 at 12:09 AM, Grant Likely
    > <grant.likely@secretlab.ca> wrote:
    > > On Sun, Jan 30, 2011 at 8:26 PM, Håvard Skinnemoen
    > > <hskinnemoen@gmail.com> wrote:
    > >> Hi,
    > >>
    > >> On Sun, Jan 30, 2011 at 7:56 AM, Thomas Chou <thomas@wytron.com.tw> wrote:
    > >>> From: Albert Herranz <albert_herranz@yahoo.es>
    > >>>
    > >>> This patch is based on an earlier patch from Albert Herranz,
    > >>> http://git.infradead.org/users/herraa1/gc-linux-2.6.git/commit/
    > >>> 9854eb78607c641ab5ae85bcbe3c9d14ac113733
    > >>
    > >> That commit has a single-line description of which I don't understand
    > >> a single word (unless "wii" is what I think it is, which seems
    > >> likely). Could you please explain how that commit relates to this
    > >> patch?
    > >
    > > The URL got wrapped.  Try this one (assuming my mailer doesn't wrap it):
    > >
    > > http://git.infradead.org/users/herraa1/gc-linux-2.6.git/commit/9854eb78607c641ab5ae85bcbe3c9d14ac113733
    >
    > Ok, that seems to be a _bit_ more related, but not that much. I'd
    > really prefer a patch description which can stand on its own.
    >
    [...]
    >
    > >> Not saying that it necessarily _is_ a terrible idea, but I think the
    > >> reasoning behind it needs to be included in the patch description.
    > >
    > > Nah, he doesn't really need to defend this since it is a well
    > > established pattern.  device tree support is in core code now (see
    > > of_node an of_match_table in include/linux/device.h), and other
    > > drivers do exactly this.
    >
    > Well, perhaps you're right, but I still think the patch description is
    > a bit on the thin side. In particular, terms like "as Grant suggested"
    > isn't very helpful for people like me who don't know what you
    > suggested (even though I'm sure it was a good suggestion).
    >
    > I think the patch lacks a good description of what's being changed and
    > why. The references may be nice to have as a supplement to that, but
    > describing things entirely in terms of some unknown e-mail discussion
    > that happened earlier is not very helpful for people who want to
    > figure out what's going on a couple of months or years from now.

    No arguments from me on those points.

    g.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-02-01 00:03    [W:2.990 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site