lkml.org 
[lkml]   [2011]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [patch 1/3] memcg: prevent endless loop when charging huge pages
    From
    On Mon, Jan 31, 2011 at 11:03 PM, Johannes Weiner <hannes@cmpxchg.org> wrote:
    > The charging code can encounter a charge size that is bigger than a
    > regular page in two situations: one is a batched charge to fill the
    > per-cpu stocks, the other is a huge page charge.
    >
    > This code is distributed over two functions, however, and only the
    > outer one is aware of huge pages.  In case the charging fails, the
    > inner function will tell the outer function to retry if the charge
    > size is bigger than regular pages--assuming batched charging is the
    > only case.  And the outer function will retry forever charging a huge
    > page.
    >
    > This patch makes sure the inner function can distinguish between batch
    > charging and a single huge page charge.  It will only signal another
    > attempt if batch charging failed, and go into regular reclaim when it
    > is called on behalf of a huge page.
    >
    > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
    Reviewed-by: Minchan Kim <minchan.kim@gmail.com>

    --
    Kind regards,
    Minchan Kim
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-01-31 23:29    [W:0.021 / U:64.572 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site