lkml.org 
[lkml]   [2011]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/7] sysdev: Do not register with sysdev when erroring on add
On Mon, Jan 24, 2011 at 04:28:57PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <borislav.petkov@amd.com>
>
> When encountering an error while executing the driver's ->add method, we
> should cancel registration and unwind what we've regged so far. The low
> level ->add methods do return proper error codes but those aren't looked
> at in sysdev_driver_register(). Fix that by sharing the unregistering
> code.

Have you actually hit this before? If so, where?

> Also, fixup warning messages formatting while at it.

Please, no, one patch per thing. Please break this up into two
different patches.
And, in the future, let me know that you need this for other work.
Actually, why did you send this to Ingo in your pull request? What does
your microcode patches need from this patch? It should go through my
tree, especially as there is other sysdev work happening at the moment.

so, no, please don't send this on to anyone else right now.

thanks,

greg k-h


\
 
 \ /
  Last update: 2011-01-31 23:19    [from the cache]
©2003-2011 Jasper Spaans