Messages in this thread | | | Subject | Re: [RFC -v7 PATCH 5/7] export pid symbols needed for kvm_vcpu_on_spin | From | Peter Zijlstra <> | Date | Mon, 31 Jan 2011 14:43:35 +0100 |
| |
On Mon, 2011-01-31 at 15:26 +0200, Avi Kivity wrote: > On 01/31/2011 01:51 PM, Peter Zijlstra wrote: > > On Wed, 2011-01-26 at 17:23 -0500, Rik van Riel wrote: > > > Export the symbols required for a race-free kvm_vcpu_on_spin. > > > > Avi, you asked for an example of why I hated KVM as a module :-) > > Why do you dislike exports so much?
Because I hate modules [*], since we sadly cannot undo those, limiting the module interface is all we've got, and KVM is one that pushes the module interface further and further.
Many people see an EXPORT as a acknowledgement that its OK to use the interface, even when its not.
[*] they enable the binary junk thing.
| |