lkml.org 
[lkml]   [2011]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: linux-next: build warning after merge of the cifs tree
    From
    2011/1/31 Suresh Jayaraman <sjayaraman@suse.de>:
    > On 01/31/2011 08:00 AM, Stephen Rothwell wrote:
    >> Hi all,
    >>
    >> After merging the cifs tree, today's linux-next build (powerpc
    >> ppc64_defconfig) produced this warning:
    >>
    >> fs/cifs/file.c: In function 'cifs_iovec_write':
    >> fs/cifs/file.c:1740: warning: passing argument 6 of 'CIFSSMBWrite2' from incompatible pointer type
    >> fs/cifs/cifsproto.h:343: note: expected 'unsigned int *' but argument is of type 'size_t *'
    >>
    >> Introduced by commit 72432ffcf555decbbae47f1be338e1d2f210aa69 ("CIFS:
    >> Implement cifs_strict_writev (try #4)").
    >>
    >
    > The following patch should silence that warning.
    >
    > From: Suresh Jayaraman <sjayaraman@suse.de>
    > Subject: [PATCH] cifs: fix compiler warning about incompatible pointer type
    >
    > fs/cifs/file.c: In function ‘cifs_iovec_write’:
    > fs/cifs/file.c:1740:9: warning: passing argument 6 of ‘CIFSSMBWrite2’ from incompatible pointer type
    > fs/cifs/cifsproto.h:343:12: note: expected ‘unsigned int *’ but argument is of type ‘size_t *’
    >
    > Cc: Pavel Shilovsky <piastryyy@gmail.com>
    > Signed-off-by: Suresh Jayaraman <sjayaraman@suse.de>
    > ---
    >  fs/cifs/file.c |    2 +-
    >  1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/fs/cifs/file.c b/fs/cifs/file.c
    > index 0de17c1..2a3c5d8 100644
    > --- a/fs/cifs/file.c
    > +++ b/fs/cifs/file.c
    > @@ -1667,7 +1667,7 @@ static ssize_t
    >  cifs_iovec_write(struct file *file, const struct iovec *iov,
    >                 unsigned long nr_segs, loff_t *poffset)
    >  {
    > -       size_t total_written = 0, written = 0;
    > +       unsigned int total_written = 0, written = 0;
    >        unsigned long num_pages, npages;
    >        size_t copied, len, cur_len, i;
    >        struct kvec *to_send;
    >

    I've just noriced another bug: that 'i' variable should be unsigned
    long. I will recreate the patch with this fix.

    --
    Best regards,
    Pavel Shilovsky.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-01-31 12:41    [W:0.029 / U:30.048 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site