lkml.org 
[lkml]   [2011]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] isdn: icn: Fix potentially wrong string handling
    Date
    This warning was reported by cppcheck:
    drivers/isdn/icn/icn.c:1641: error: Dangerous usage of 'rev' (strncpy doesn't always 0-terminate it)

    If strncpy copied 20 bytes, the destination string rev was not terminated.
    The patch adds one more byte to rev and makes sure that this byte is
    always 0.

    Cc: Karsten Keil <isdn@linux-pingi.de>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Tejun Heo <tj@kernel.org>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: netdev@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: Stefan Weil <weil@mail.berlios.de>
    ---
    drivers/isdn/icn/icn.c | 15 ++++++++-------
    1 files changed, 8 insertions(+), 7 deletions(-)

    diff --git a/drivers/isdn/icn/icn.c b/drivers/isdn/icn/icn.c
    index f2b5bab..540c181 100644
    --- a/drivers/isdn/icn/icn.c
    +++ b/drivers/isdn/icn/icn.c
    @@ -1627,7 +1627,7 @@ __setup("icn=", icn_setup);
    static int __init icn_init(void)
    {
    char *p;
    - char rev[20];
    + char rev[21];

    memset(&dev, 0, sizeof(icn_dev));
    dev.memaddr = (membase & 0x0ffc000);
    @@ -1638,6 +1638,7 @@ static int __init icn_init(void)

    if ((p = strchr(revision, ':'))) {
    strncpy(rev, p + 1, 20);
    + rev[20] = '\0';
    p = strchr(rev, '$');
    if (p)
    *p = 0;
    --
    1.7.2.3


    \
     
     \ /
      Last update: 2011-01-30 21:33    [W:0.021 / U:60.892 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site