Messages in this thread | | | Date | Sun, 30 Jan 2011 16:04:41 +0200 | From | Avi Kivity <> | Subject | Re: [PATCH v2 3/6] KVM-GST: KVM Steal time accounting |
| |
On 01/28/2011 09:52 PM, Glauber Costa wrote: > This patch accounts steal time time in kernel/sched. > I kept it from last proposal, because I still see advantages > in it: Doing it here will give us easier access from scheduler > variables such as the cpu rq. The next patch shows an example of > usage for it. > > Since functions like account_idle_time() can be called from > multiple places, not only account_process_tick(), steal time > grabbing is repeated in each account function separatedely. >
I accept that steal time is worthwhile, but do you have some way to demonstrate that the implementation actually works and is beneficial?
Perhaps run two cpu-bound compute processes on one vcpu, overcommit that vcpu, and see what happens to the processing rate with and without steal time accounting. I'd expect a fairer response with steal time accounting.
-- error compiling committee.c: too many arguments to function
| |