lkml.org 
[lkml]   [2011]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5/7] perf: Optimise topology iteration
From
Date
On Mon, 2010-12-27 at 23:38 +0800, Lin Ming wrote:
> Currently we iterate the full machine looking for a matching core_id/nb
> for the percore and the amd northbridge stuff , using a smaller topology
> mask makes sense.

Does topology_thread_cpumask() include offline cpus? I tried looking at
it, but I cannot find any code clearing bits in that mask on offline.

> Signed-off-by: Lin Ming <ming.m.lin@intel.com>
> ---
> arch/x86/kernel/cpu/perf_event_amd.c | 2 +-
> arch/x86/kernel/cpu/perf_event_intel.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/perf_event_amd.c b/arch/x86/kernel/cpu/perf_event_amd.c
> index 67e2202..5a3b7b8 100644
> --- a/arch/x86/kernel/cpu/perf_event_amd.c
> +++ b/arch/x86/kernel/cpu/perf_event_amd.c
> @@ -323,7 +323,7 @@ static void amd_pmu_cpu_starting(int cpu)
> nb_id = amd_get_nb_id(cpu);
> WARN_ON_ONCE(nb_id == BAD_APICID);
>
> - for_each_online_cpu(i) {
> + for_each_cpu(i, topology_core_cpumask(cpu)) {
> nb = per_cpu(cpu_hw_events, i).amd_nb;
> if (WARN_ON_ONCE(!nb))
> continue;
> diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
> index 354d1de..ad70c2c 100644
> --- a/arch/x86/kernel/cpu/perf_event_intel.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel.c
> @@ -1111,7 +1111,7 @@ static void intel_pmu_cpu_starting(int cpu)
> if (!ht_enabled(cpu))
> return;
>
> - for_each_online_cpu(i) {
> + for_each_cpu(i, topology_thread_cpumask(cpu)) {
> struct intel_percore *pc = per_cpu(cpu_hw_events, i).per_core;
>
> if (pc && pc->core_id == core_id) {




\
 
 \ /
  Last update: 2011-01-03 12:05    [W:0.652 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site