lkml.org 
[lkml]   [2011]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/7] perf: Optimise topology iteration
    On Mon, Jan 03, 2011 at 12:02:10PM +0100, Peter Zijlstra wrote:
    > On Mon, 2010-12-27 at 23:38 +0800, Lin Ming wrote:
    > > Currently we iterate the full machine looking for a matching core_id/nb
    > > for the percore and the amd northbridge stuff , using a smaller topology
    > > mask makes sense.
    >
    > Does topology_thread_cpumask() include offline cpus? I tried looking at
    > it, but I cannot find any code clearing bits in that mask on offline.

    The problem is not only at offline, but also at online between CPUs
    going online. I don't think the patch is a good idea and it doesn't
    even have any advantages either since this is a initialization only
    slow path.

    -Andi


    \
     
     \ /
      Last update: 2011-01-03 16:23    [W:4.205 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site