lkml.org 
[lkml]   [2011]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] Fix prlimit64 for suid/sgid processes
On 01/29/2011 12:21 AM, Kacper Kornet wrote:
> Since check_prlimit_permission always fails in the case of SUID/GUID
> processes, such processes are not able to read or set their own limits.
> This commit changes this by assuming that process can always read/change
> its own limits.
>
> Signed-off-by: Kacper Kornet <kornet@camk.edu.pl>

ACK. The check comes from the ptrace code. I forgot to copy this test.

> ---
> kernel/sys.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/sys.c b/kernel/sys.c
> index e9ad444..03bead7 100644
> --- a/kernel/sys.c
> +++ b/kernel/sys.c
> @@ -1375,7 +1375,8 @@ static int check_prlimit_permission(struct task_struct *task)
> const struct cred *cred = current_cred(), *tcred;
>
> tcred = __task_cred(task);
> - if ((cred->uid != tcred->euid ||
> + if (current != task &&
> + (cred->uid != tcred->euid ||
> cred->uid != tcred->suid ||
> cred->uid != tcred->uid ||
> cred->gid != tcred->egid ||

thanks,
--
js
suse labs


\
 
 \ /
  Last update: 2011-01-29 00:31    [W:0.048 / U:12.560 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site