[lkml]   [2011]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH V10 01/15] time: Introduce timekeeping_inject_offset
On Thu, Jan 27, 2011 at 10:48:19AM -0800, John Stultz wrote:
> While I appreciate you preserving the path author, and the signoffs are
> right, you really should send the email under your own name.

Guess I've been reading too much spam. It wore off on me.

> The proper style is to keep the mail-header From: the same (ie: Richard
> Cochran <>), but as the first line of the mail
> body put:
> From: Author Name <>

Sorry about this. Arnd already explained this to me, and I did catch
it with V9. This time I forgot.

I would like to get to the bottom of this. Here is what I did:

1. Saved your patch to disk in mbox format using Mutt.
2. git am
3. ... rebase, rebase, rebase, ...
4. git format-patch [options] 1234..abcd
5. Edit cover letter
6. for x in 00*; do mutt -H $x; done

Git format-patch places the "From: John Stultz <>"
line with the other mail headers, and so I guess mutt just faithfully
preserves this.

I don't like having to remember to fix this manually. There must be a
better way...


 \ /
  Last update: 2011-01-28 08:11    [W:0.059 / U:9.284 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site