lkml.org 
[lkml]   [2011]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/1] drivers: rtc: Add module_put on error path in rtc_proc_open
Date
From: Alexander Strakh <cromlehg@gmail.com>

In file drivers/rtc/rtc-proc.c in linux-2.6.37:

The seq_open function can return -ENOMEM.

86 if (!try_module_get(THIS_MODULE))
87 return -ENODEV;
88
89 return single_open(file, rtc_proc_show, rtc);

In this case before exiting (line 89) from rtc_proc_open
the module_put(THIS_MODULE) must be called.

Found by Linux Device Drivers Verification Project

Signed-off-by: Alexander Strakh <strakh@ispras.ru>
---
drivers/rtc/rtc-proc.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/rtc/rtc-proc.c b/drivers/rtc/rtc-proc.c
index c086fc3..242bbf8 100644
--- a/drivers/rtc/rtc-proc.c
+++ b/drivers/rtc/rtc-proc.c
@@ -81,12 +81,16 @@ static int rtc_proc_show(struct seq_file *seq, void *offset)

static int rtc_proc_open(struct inode *inode, struct file *file)
{
+ int ret;
struct rtc_device *rtc = PDE(inode)->data;

if (!try_module_get(THIS_MODULE))
return -ENODEV;

- return single_open(file, rtc_proc_show, rtc);
+ ret = single_open(file, rtc_proc_show, rtc);
+ if (ret)
+ module_put(THIS_MODULE);
+ return ret;
}

static int rtc_proc_release(struct inode *inode, struct file *file)
--
1.7.1


\
 
 \ /
  Last update: 2011-01-28 13:55    [W:0.055 / U:7.504 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site