lkml.org 
[lkml]   [2011]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Ocfs2-devel] fs/ocfs2/dlm: Use GFP_ATOMIC under spin_lock
On Thu, 27 Jan 2011 17:28:53 -0800 Sunil Mushran <sunil.mushran@oracle.com> wrote:

> > return status;
> > }
> >
> > @@ -1077,6 +1069,7 @@ static int dlm_query_region_handler(stru
> > struct dlm_ctxt *dlm = NULL;
> > int status = 0;
> > int locked = 0;
> > + static u8 local[sizeof(qr->qr_regions)]; /* locked by dlm_domain_lock */
> >
> > qr = (struct dlm_query_region *) msg->buf;
> >
> > @@ -1112,7 +1105,7 @@ static int dlm_query_region_handler(stru
> > goto bail;
> > }
> >
> > - status = dlm_match_regions(dlm, qr);
> > + status = dlm_match_regions(dlm, qr, local);
> >
> > bail:
> > if (locked)
>
> That sizeof() is 1K. It maybe better if we moved the kmalloc() here.

That would work too. As it's only called at mount time, the
speed/space tradeoff favours kmalloc().



\
 
 \ /
  Last update: 2011-01-28 02:51    [W:0.059 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site