lkml.org 
[lkml]   [2011]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: rwsem: rwsem: Remove redundant asmregparm annotation
    On Thu, 27 Jan 2011, David Howells wrote:

    > Thomas Gleixner <tglx@linutronix.de> wrote:
    >
    > > Peter Zijlstra pointed out, that the only user of asmregparm (x86) is
    > > compiling the kernel already with -mregparm=3. So the annotation of
    > > the rwsem functions is redundant. Remove it.
    >
    > That's fine - as long as we never remove the -mregparm=3 on i386. The inline
    > assembly relies on the regparm=3 calling convention.

    If we remove that we'll break more than rwsems :)

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2011-01-27 16:15    [W:0.032 / U:33.216 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site