Messages in this thread | | | Subject | Re: [PATCH v2] x25: remove the BKL | From | Eric Dumazet <> | Date | Thu, 27 Jan 2011 14:20:47 +0100 |
| |
Le jeudi 27 janvier 2011 à 13:38 +0100, Arnd Bergmann a écrit : > diff --git a/net/x25/x25_out.c b/net/x25/x25_out.c > index d00649f..f1a6ff1 100644 > --- a/net/x25/x25_out.c > +++ b/net/x25/x25_out.c > @@ -68,8 +68,11 @@ int x25_output(struct sock *sk, struct sk_buff *skb) > frontlen = skb_headroom(skb); > > while (skb->len > 0) { > - if ((skbn = sock_alloc_send_skb(sk, frontlen + max_len, > - noblock, &err)) == NULL){ > + release_sock(sk); > + skbn = sock_alloc_send_skb(sk, frontlen + max_len, > + 1, &err); > + lock_sock(sk); > + if (!skbn) { > if (err == -EWOULDBLOCK && noblock){ > kfree_skb(skb); > return sent;
This part looks strange :
noblock variable became "const 1 : NOBLOCK"
Why releasing socket if you dont block in sock_alloc_send_skb() ?
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |