Messages in this thread Patch in this message | | | Date | Wed, 26 Jan 2011 07:19:02 GMT | From | tip-bot for Han Pingtian <> | Subject | [tip:perf/core] perf test: check if cpu_map__new() return NULL |
| |
Commit-ID: 98d77b78504a423fca911a26a17bee00ef2fdda2 Gitweb: http://git.kernel.org/tip/98d77b78504a423fca911a26a17bee00ef2fdda2 Author: Han Pingtian <phan@redhat.com> AuthorDate: Sat, 15 Jan 2011 07:00:50 +0800 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Sat, 22 Jan 2011 19:56:30 -0200
perf test: check if cpu_map__new() return NULL
It looks like we should check if cpus is NULL after
cpus = cpu_map__new(NULL);
in test__open_syscall_event_on_all_cpus().
LKML-Reference: <20110114230050.GA7011@localhost> Signed-off-by: Han Pingtian <phan@redhat.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/builtin-test.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/builtin-test.c b/tools/perf/builtin-test.c index 7cc6b20..5a50e47 100644 --- a/tools/perf/builtin-test.c +++ b/tools/perf/builtin-test.c @@ -347,9 +347,9 @@ static int test__open_syscall_event_on_all_cpus(void) } cpus = cpu_map__new(NULL); - if (threads == NULL) { - pr_debug("thread_map__new\n"); - return -1; + if (cpus == NULL) { + pr_debug("cpu_map__new\n"); + goto out_thread_map_delete; }
| |