Messages in this thread | | | From | Coly Li <> | Subject | [PATCH 0/6] use BUG_ON correctly | Date | Thu, 27 Jan 2011 02:54:49 +0800 |
| |
BUG_ON() already uses unlikely() inside its definition if possible, therefore code should not use BUG_ON() with explicit unlikely() like BUG_ON(unlikely(...)), an explicit unlikely() doesn't make things better.
This patch set fixes all incorrect usage of BUG_ON() as the above line mentioned.
Signed-off-by: Coly Li <bosong.ly@taobao.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Greg KH <gregkh@suse.de> --- drivers/dma/iop-adma.c | 6 +++--- drivers/dma/mv_xor.c | 6 +++--- drivers/dma/ppc4xx/adma.c | 8 ++++---- drivers/scsi/scsi_lib.c | 4 ++-- drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 14 +++++++------- mm/nommu.c | 10 +++++----- 6 files changed, 24 insertions(+), 24 deletions(-)
| |