lkml.org 
[lkml]   [2011]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] power_trace: move power_trace to kernel/power/

* Lai Jiangshan <laijs@cn.fujitsu.com> wrote:

>
> I think kernel/trace/ is the place for the tracing implementation files,
> it is not a good place for tracepoint creation. Any subsystem should
> creates tracepoints at its owner location, see also all other CREATE_TRACE_POINTS.
> For example: net-traces.c is in the net/core/ directory.
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/kernel/Makefile b/kernel/Makefile
> index 353d3fe..25c3767 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -55,6 +55,7 @@ obj-$(CONFIG_MODULES) += module.o
> obj-$(CONFIG_KALLSYMS) += kallsyms.o
> obj-$(CONFIG_PM) += power/
> obj-$(CONFIG_FREEZER) += power/
> +obj-$(CONFIG_TRACEPOINTS) += power/
> obj-$(CONFIG_BSD_PROCESS_ACCT) += acct.o
> obj-$(CONFIG_KEXEC) += kexec.o
> obj-$(CONFIG_BACKTRACE_SELF_TEST) += backtracetest.o
> @@ -100,7 +101,6 @@ obj-$(CONFIG_FUNCTION_TRACER) += trace/
> obj-$(CONFIG_TRACING) += trace/
> obj-$(CONFIG_X86_DS) += trace/
> obj-$(CONFIG_RING_BUFFER) += trace/
> -obj-$(CONFIG_TRACEPOINTS) += trace/
> obj-$(CONFIG_SMP) += sched_cpupri.o
> obj-$(CONFIG_IRQ_WORK) += irq_work.o
> obj-$(CONFIG_PERF_EVENTS) += perf_event.o
> diff --git a/kernel/power/Makefile b/kernel/power/Makefile
> index c350e18..b5a74f5 100644
> --- a/kernel/power/Makefile
> +++ b/kernel/power/Makefile
> @@ -9,3 +9,4 @@ obj-$(CONFIG_HIBERNATION) += hibernate.o snapshot.o swap.o user.o \
> block_io.o
>
> obj-$(CONFIG_MAGIC_SYSRQ) += poweroff.o
> +obj-$(CONFIG_TRACEPOINTS) += power-traces.o

What is 'power-traces'? Please name it power-events.c/power-events.o.

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-01-26 12:07    [W:0.087 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site