lkml.org 
[lkml]   [2011]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC] [PATCH 2.6.37-rc5-tip 5/20] 5: Uprobes: register/unregister probes.
From
Date
On Wed, 2011-01-26 at 13:25 +0530, Srikar Dronamraju wrote:
>
> > > +
> > > + list_add(&mm->uprobes_list, &tmp_list);
> > > + mm->uprobes_vaddr = vma->vm_start + offset;
> > > + }
> > > + spin_unlock(&mapping->i_mmap_lock);
> >
> > Both this and unregister are racy, what is to say:
> > - the vma didn't get removed from the mm
> > - no new matching vma got added
> >
>
> register_uprobe, unregister_uprobe, uprobe_mmap are all synchronized by
> uprobes_mutex. So I dont see one unregister_uprobe getting thro when
> another register_uprobe is working with a vma.
>
> If I am missing something elementary, please explain a bit more.

afaict you're not holding the mmap_sem, so userspace can simply unmap
the vma.


\
 
 \ /
  Last update: 2011-01-26 11:13    [W:0.142 / U:1.068 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site