Messages in this thread | | | Date | Tue, 25 Jan 2011 08:41:56 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH] fix build error when CONFIG_SWAP is not set |
| |
> From: Andrew Morton <akpm@linux-foundation.org> > > mips: > > In file included from arch/mips/include/asm/tlb.h:21, > from mm/pgtable-generic.c:9: > include/asm-generic/tlb.h: In function `tlb_flush_mmu': > include/asm-generic/tlb.h:76: error: implicit declaration of function `release_pages' > include/asm-generic/tlb.h: In function `tlb_remove_page': > include/asm-generic/tlb.h:105: error: implicit declaration of function `page_cache_release' > > free_pages_and_swap_cache() and free_page_and_swap_cache() are macros > which call release_pages() and page_cache_release(). The obvious fix is > to include pagemap.h in swap.h, where those macros are defined. But that > breaks sparc for weird reasons. > > So fix it within mm/pgtable-generic.c instead. > > Reported-by: Yoichi Yuasa <yuasa@linux-mips.org> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Sergei Shtylyov <sshtylyov@mvista.com> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
I have succesfully build sparc32 allnoconfig + defconfig with this patch. Can you expand the changelog to specify that this fixes sparc32 allnoconfig as well?
Consider it: Acked-by: Sam Ravnborg <sam@ravnborg.org>
Sam
| |