Messages in this thread | | | Date | Tue, 25 Jan 2011 21:57:54 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH 4/4] drivers/staging/lirc: Remove obsolete cleanup for clientdata |
| |
On Mon, Jan 24, 2011 at 07:09:02PM -0500, Andy Walls wrote: > On Mon, 2011-01-24 at 11:44 +0100, Wolfram Sang wrote: > > A few new i2c-drivers came into the kernel which clear the clientdata-pointer > > on exit or error. This is obsolete meanwhile, the core will do it. Simplify the > > kfree() calls after that, the pointers don't need to be checked. > > > > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> > > Cc: Greg Kroah-Hartman <gregkh@suse.de> > > Cc: Mauro Carvalho Chehab <mchehab@redhat.com> > > Cc: Andy Walls <awalls@md.metrocast.net> > > Nak. > > In a module where I plan to do more cleanup and add reference counting > to struct IR, IR_tx, and IR_rx objects, I'd like the explicit "NULL"s in > pointer checks to stay in for now.
Okay, I will ignore this driver until it comes out of staging.
Thanks,
Wolfram
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |