lkml.org 
[lkml]   [2011]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC] [PATCH 2.6.37-rc5-tip 8/20] 8: uprobes: mmap and fork hooks.
From
Date
On Tue, 2011-01-25 at 13:15 +0100, Peter Zijlstra wrote:
> On Thu, 2010-12-16 at 15:28 +0530, Srikar Dronamraju wrote:

> > +static void search_within_subtree(struct rb_node *n, struct inode *inode,
> > + struct list_head *tmp_list)
> > +{
> > + struct rb_node *p;
> > +
> > + if (p)
> > + __search_within_subtree(p, inode, tmp_list);
> > +
> > + p = n->rb_right;
> > + if (p)
> > + __search_within_subtree(p, inode, tmp_list);
> > +}
>
> Whee recursion FTW!, you just blew your kernel stack :-)
>
> Since you sort inode first, offset second, I think you can simply look
> for the first matching inode entry and simply rb_next() until you don't
> match.

Not to mention that p is uninitialized. Did this code ever work?

-- Steve




\
 
 \ /
  Last update: 2011-01-25 21:07    [W:0.222 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site