lkml.org 
[lkml]   [2011]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 28/28] ARM: tegra: clock: Add forward reference to struct clk
    From
    On Mon, Jan 24, 2011 at 2:26 AM, Russell King - ARM Linux
    <linux@arm.linux.org.uk> wrote:
    > On Sun, Jan 23, 2011 at 06:01:33PM -0800, Colin Cross wrote:
    >> diff --git a/arch/arm/mach-tegra/include/mach/clkdev.h b/arch/arm/mach-tegra/include/mach/clkdev.h
    >> index 412f5c6..66cd3f4 100644
    >> --- a/arch/arm/mach-tegra/include/mach/clkdev.h
    >> +++ b/arch/arm/mach-tegra/include/mach/clkdev.h
    >> @@ -20,6 +20,8 @@
    >>  #ifndef __MACH_CLKDEV_H
    >>  #define __MACH_CLKDEV_H
    >>
    >> +struct clk;
    >> +
    >>  static inline int __clk_get(struct clk *clk)
    >>  {
    >>       return 1;
    >
    > If you're having to add that, I suspect this include is being
    > inappropriately included by files.
    >

    The Tegra clock definition file, arch/arm/mach-tegra/tegra2_clocks.c,
    includes the private clock.h that defines struct clk after including
    linux/clkdev.h, and does not include linux/clk.h, so the forward
    declaration is necessary.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-01-25 02:25    [W:0.021 / U:60.104 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site